Cache lix installer #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antifuchs
force-pushed
the
cache-lix-installer
branch
3 times, most recently
from
46fa555 to
228662a
Compare
This uses curl's --etag-save and --etag-compare functions to see if we need a new installer and only then download it.
antifuchs
force-pushed
the
cache-lix-installer
branch
from
228662a to
9ad404e
Compare
samueldr
reviewed
Feb 28, 2025
|
please rebase the |
samueldr
reviewed
Feb 28, 2025
antifuchs
force-pushed
the
cache-lix-installer
branch
from
55e3e86 to
73a9082
Compare
|
My cache entries look like this now: I think the cache action will update the cache entries whenever the etag changes, but I'm not sure we can test this in any way ahead of time. |
samueldr
reviewed
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #4 by replicating the functionality of the download-and-run installer script (as it advises users do), adding etag cache invalidation.
It then uses the "actions/cache" action to store the etag value and the lix installer the GHA cache.